Add missing dependency and a test for dependencies #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-costas
force-pushed
the
fix-librest
branch
from
c991ea0
to
ce63026
Compare
The conditioning stage wasn't dependent on librest, so it could be done before, thus not "fixing" the .pc files of librest. Also, this PR adds a tool to check dependencies, a tool to check them, and an automated test for github.
sergio-costas
force-pushed
the
fix-librest
branch
from
ce63026
to
6e46915
Compare
buildenv is not required to depend on
sergio-costas
changed the title
We must use a different way to ensure that all the dependencies are correct, because the python YAML module doesn't guarantee that the order is preserved, so, since the parts could be returned in a different order, we can't stop when we find "debs".
jssotomdz
approved these changes
Sep 19, 2024
sergio-costas
requested review from
seb128
and removed request for
kenvandine
seb128
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditioning stage wasn't dependent on librest, so it could be done before, thus not "fixing" the .pc files of librest. Also, it lacked dependency on at-spi2-core and webp-pixbuf-loader.
This PR fixes this and also adds a github test to ensure that any new PR with new parts guarantee that DEBS depend on it.